This is the mail archive of the cygwin mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: MSYS mode (continue)


On Jul  4 13:09, Alexey Pavlov wrote:
> 2013-06-18  Alexey Pavlov
> 
> * mount.cc: Allow using a shortened version of mount points in /etc/fstab
> * utsname.h: Increase sysname fiels size.
> * uname.cc: Allow changing OS name by MSYSTEM environment variable.
> [...SNIP...]

Can we please move patch submissions to the cygwin-patches mailing list?
Thank you.

> Index: cygwin/include/sys/utsname.h
> ===================================================================
> RCS file: /cvs/src/src/winsup/cygwin/include/sys/utsname.h,v
> retrieving revision 1.3
> diff -u -p -r1.3 utsname.h
> --- cygwin/include/sys/utsname.h 21 Jan 2013 04:38:31 -0000 1.3
> +++ cygwin/include/sys/utsname.h 18 Jun 2013 11:39:27 -0000
> @@ -17,7 +17,7 @@ extern "C" {
> 
>  struct utsname
>  {
> -  char sysname[20];
> +  char sysname[21];

We can't do that.  struct utsname is a publically facing structure.
If you change the size, you're breaking compatibility with existing
applications.

You should better drop some character from the string you want to enter
here.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]