Re: Performance problems with emacs-X11 in current cygwin

[Ken Brown <kbrown at cornell dot edu>]

On 6/10/2012 8:45 PM, Ken Brown wrote:
> The bisection shows that the first problematic commit is this one:
>
> http://git.gnome.org/browse/glib/commit/?h=glib-2-32&id=7eae486179e2799c369ed9ffcea663bf9161ce79
>
>
> Author: Ryan Lortie <desrt@desrt.ca>
> Date: Wed Aug 31 22:07:02 2011 -0400
>
> GMain: simplify logic for g_wakeup_acknowledge()
>
> Instead of messing around with context->poll_waiting, just look at the
> GPollFD to see if the GWakeup needs to be acknowledged.

I think this commit contains a typo: "events" should be "revents". 
(context->wake_up_rec.events is always nonzero at this point in the 
code, so it makes no sense to test that.)  As a result, 
g_wakeup_acknowledge() is being called much more often than necessary. 
I think this could easily explain the performance problems that have 
been reported, but I won't have a chance to test this on my (slow) XP 
system for a while, and possibly not until tomorrow.

Ken

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple