This is the mail archive of the cygwin mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: 1.7.7: rm -rf sometimes fails - race condition?


On Dec 12 15:21, Matthias Andree wrote:
> BTW, haven't read through all of
> <http://cygwin.com/cgi-bin/cvsweb.cgi/src/winsup/cygwin/syscalls.cc?annotate=1.570&cvsroot=src>
> 
> for lack of time, but check_dir_not_empty wastes CPU time on full directories -
> you don't need to count to 1000 -- see the while loop ll. 515 - 520, the if() {}

It only wastes marginally time since the size of the structure doesn't
hold a lot of files, 3 with a name length of 255 chars, 58 with a length
of 1 char.  But you're right, I'll move the test into the loop.


Thx,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]