This is the mail archive of the cygwin mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: msync failure due to rounding up length (with test case and suggested fix)


On Jul 18 20:36, Neal Norwitz wrote:
> See winsup/cygwin/mmap.cc line 1355 in current CVS (msync function):
> 
>  len = roundup2 (len, pagesize);
> 
> I verified my suspicion that roundup2() is causing Python's test suite
> to fail.

Thanks for the testcase.  I agree that rounding up len is wrong.
Unfortunately I have no recollection why I added this and I missed to
add a comment apparently <mental note>add more comments</mental note>.
I removed it now.


Thanks again for the testcase,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]