This is the mail archive of the cygwin mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: ":" in filename


On Sat, 25 Mar 2006, Larry Hall (Cygwin) wrote:

> Eric Blake wrote:
>
> <snip>
>
> > It would be nice if cygwin could be more proactive in recognizing : as
> > invalid in non-managed mounts, rather than passing the : on to the
> > Windows filename functions, in order to avoid the creation of
> > undeletable filenames such as ".new." via the help of a colon, but I
> > can live with the current behavior if adding such a check would slow
> > down the common case.
>
> The latter affect is certainly the case here though, as usual, I'm sure
> it's a PTC if someone has a great brainstorm for a way to do this
> without the overhead.

Well, normalize_posix_path() (in path.cc) already scans the whole path
string looking for '\\' -- I can't imagine that adding a check for ':'
would introduce all that much overhead.  But, of course, empirical
evidence is always best, and I don't have any at the moment.

Eric, care to simply add a test for ':' in that loop and do some
measurements?
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_	    pechtcha@cs.nyu.edu | igor@watson.ibm.com
ZZZzz /,`.-'`'    -.  ;-;;,_		Igor Peshansky, Ph.D. (name changed!)
     |,4-  ) )-,_. ,\ (  `'-'		old name: Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte."
"But no -- you are no fool; you call yourself a fool, there's proof enough in
that!" -- Rostand, "Cyrano de Bergerac"

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]