This is the mail archive of the cygwin mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: lstat on FAT - Was: Problem with find on FAT drives


At 03:03 PM 3/26/2004 -0500, Christopher Faylor wrote:
>[just to provide a non-flip answer to this subject]
>On Wed, Mar 24, 2004 at 09:39:29PM -0500, Pierre A. Humblet wrote:
>>On Wed, Mar 24, 2004 at 04:42:39PM -0500, Christopher Faylor wrote:
>>I wonder if 
>>      char *p = strrchr (src, '\0');
>>      /* Detect if the user was looking for a directory.  We have to
strip the
>>should be inside the symlink loop or outside. I guess that depends if
>>symlink contents ending with / are special (on Sun the final / is
stripped in
>>symlinks, dunno about other Unix flavors).
>
>I really hated putting that in there to begin with (and it should be a
>'strchr' anyway) but it was required because Windows allows you to say
>/foo/bar/ and even /foo/bar/. even when bar isn't a directory.  I don't
>believe that the code would work right if that wasn't there.  It would
>allow a symlink to /foo/bar/. to work when it shouldn't.

OK, but there are two other related issues:

On Sun
1-everest$ ln -s /etc/passwd/ pw
1-everest$ tail -1 pw
+:x:::::/var/adm/local/nologinsh
1-everest$ ls -l pw
lrwxrwxrwx   1 humblet  cm            11 Mar 27 17:49 pw -> /etc/passwd
                 (note the final / is gone)
On Cygwin:
~: ln -s /etc/passwd/ pw
~: tail -1 pw
tail: pw: No such device or address   (because the test is in the symlink
loop)
~: ls -l pw
lrwxrwxrwx    1 pierre   all           121 Mar 27 11:47 pw -> /etc/passwd/

And also
On Sun:
1-everest$ ln -s /etc et
1-everest$ ls -ld et
lrwxrwxrwx   1 humblet  cm             4 Mar 27 17:52 et -> /etc
1-everest$ ls -ld et/
lrwxrwxrwx   1 humblet  cm             4 Mar 27 17:52 et/ -> /etc
  Note that the results are identical

On Cygwin:
~: ln -s /etc et
~: /bin/ls -ld et 
lrwxrwxrwx    1 pierre   all           106 Mar 27 11:54 et -> /etc
~: /bin/ls -ld et/
drwxr-xr-x   11 pierre   all             0 Oct 12  2001 et/
  Here they differ.

Can someone check how Linux behaves in these cases?

>>Also normalize_posix_path strips the final /, except when it calls 
>>normalize_win32_path. That makes the code go through extra hoops
>>when resolving c:/the/symlink/, it looks for c:/the/symlink/.lnk
>
>I suppose that should be fixed.

Will do, after 1.5.10 is released. Don't want to break it while
fixing weird corner cases.

Pierre


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]