RE: setup.exe (cinstall) bugfixes + minor new feature

["Robert Collins" <robert dot collins at itdomain dot com dot au>]

Thanks Max.

> -----Original Message-----
> From: Max Bowsher [mailto:maxb@ukf.net] 
> Sent: Monday, March 04, 2002 4:54 AM
> To: cygwin@cygwin.com
> Subject: setup.exe (cinstall) bugfixes + minor new feature
> 
> 
> I've been working with the setup code, and have discovered 
> some bugs in the current (just updated) CVS version.
> 
> I'm posting a patch here for comments, whilst I join 
> cygwin-patches, and study the Contributing instructions.
> 
> The patch does the following:
> 
> BugFix: io_stream::mkpath_p(isadir, path) misuse
> mkpath_p is supposed to take a path with either a file:// or 
> a cygfile:// prefix, but it is fed a path with no prefix in 
> some places. The patch adds a file:// prefix where needed. 
> This was causing some directories not to be created, 
> including the Cygwin directory in the start menu.

I know about these - they are fixed in setup200202 - when that goes live
I'll be backporting some key bugs. 
 
> BugFix: add backslash call to make_link, in desktop.cc
> This was causing the start menu shortcut to be called 
> 'Programs/Cygwin/Cygwin Bash Shell' instead of being in the 
> correct directory structure

Does this affect setup200202? I haven't checked yet. I'm trying to
encpasulate the path specific knowledge - so whilst this solution works,
I'd rather refactor make_link to leverage io_stream, and make this a
method or variant of the file:// io_stream. Also '/' separated paths are
valid to pass to the WIN32 API, so I'm curious why this is suddenly
become a problem. (Quite a lot of setup expects '/' separated paths, and
I see no reason to change that at this point.
 
> Feature Addition: Use files 
> /etc/setup/inhibit-{startmenu,desktop}-icon to remeber user 
> de-selection of the create icon checkboxes on the last page of setup.

This approach is too simple - it will only remember turning them off.
The settings should go in /etc/setup/setup.conf as something like
"desktop_icon = yes|no". 

Thanks for the patch though, I look forward to an update.

Cheers,
Rob

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/