This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] cygwin: export wmempcpy


On Nov 29 19:48, Yaakov Selkowitz wrote:
> Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
> ---
> Obviously this depends on the newlib implementation patch.
> 
>  winsup/cygwin/common.din               | 1 +
>  winsup/cygwin/include/cygwin/version.h | 3 ++-
>  winsup/doc/posix.xml                   | 1 +
>  3 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/winsup/cygwin/common.din b/winsup/cygwin/common.din
> index a482cf2b7..14b9c2c18 100644
> --- a/winsup/cygwin/common.din
> +++ b/winsup/cygwin/common.din
> @@ -1609,6 +1609,7 @@ wmemchr NOSIGFE
>  wmemcmp NOSIGFE
>  wmemcpy NOSIGFE
>  wmemmove NOSIGFE
> +wmempcpy NOSIGFE
>  wmemset NOSIGFE
>  wordexp NOSIGFE
>  wordfree NOSIGFE
> diff --git a/winsup/cygwin/include/cygwin/version.h b/winsup/cygwin/include/cygwin/version.h
> index d8bb3ee44..7510f42b0 100644
> --- a/winsup/cygwin/include/cygwin/version.h
> +++ b/winsup/cygwin/include/cygwin/version.h
> @@ -489,12 +489,13 @@ details. */
>         __stack_chk_fail, __stack_chk_guard, __stpcpy_chk, __stpncpy_chk,
>         __strcat_chk, __strcpy_chk, __strncat_chk, __strncpy_chk,
>         __vsnprintf_chk, __vsprintf_chk.
> +  321: Export wmempcpy.
>  
>    Note that we forgot to bump the api for ualarm, strtoll, strtoull,
>    sigaltstack, sethostname. */
>  
>  #define CYGWIN_VERSION_API_MAJOR 0
> -#define CYGWIN_VERSION_API_MINOR 320
> +#define CYGWIN_VERSION_API_MINOR 321
>  
>  /* There is also a compatibity version number associated with the shared memory
>     regions.  It is incremented when incompatible changes are made to the shared
> diff --git a/winsup/doc/posix.xml b/winsup/doc/posix.xml
> index c99e003ba..ab574300f 100644
> --- a/winsup/doc/posix.xml
> +++ b/winsup/doc/posix.xml
> @@ -1396,6 +1396,7 @@ also IEEE Std 1003.1-2008 (POSIX.1-2008).</para>
>      wcstoll_l
>      wcstoul_l
>      wcstoull_l
> +    wmempcpy
>  </screen>
>  
>  </sect1>
> -- 
> 2.15.0

Basically ok, but shouldn't we use the assembler implementation of
memcpy/wmemcpy in miscfuncs.cc for x86_64 mempcpy/wmempcpy as well?


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: signature.asc
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]