This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 06/11] Remove always true nonnull check on "this" pointer.


On Sat, Mar 19, 2016 at 1:45 PM, Peter Foley <pefoley2@pefoley.com> wrote:
> G++ 6.0 can assert that the this pointer is non-null for member functions.
>
> winsup/cygserver/ChangeLog
> process.cc (submission_loop::request_loop): Remove nonnull check on this.
> process.cc (sync_wait_array): Ditto.
> process.cc (check_and_remove_process): Ditto.
> threaded_queue.cc (add_submission_loop): Ditto.
> threaded_queue.cc (add): Ditto.
> threaded_queue.cc (start): Ditto.
> threaded_queue.cc (stop): Ditto.
>
> winsup/cygwin/ChangeLog
> fhandler_dsp.cc (Audio_out::buf_info): Remove nonnull check on this.
> fhandler_dsp.cc (Audio_in::buf_info): Ditto.
> path.cc (fcwd_access_t::Free): Ditto.
> pinfo.cc (_pinfo::exists): Ditto.
> pinfo.cc (_pinfo::commune_request): Ditto.
> pinfo.cc (_pinfo::pipe_fhandler): Ditto.
> pinfo.cc (_pinfo::fd): Ditto.
> pinfo.cc (_pinfo::fds): Ditto.
> pinfo.cc (_pinfo::root): Ditto.
> pinfo.cc (_pinfo::cwd): Ditto.
> pinfo.cc (_pinfo::cmdline): Ditto.
> signal.cc (_pinfo::kill): Ditto.
>
> Signed-off-by: Peter Foley <pefoley2@pefoley.com>
> ---
>  winsup/cygserver/process.cc        |  3 ---
>  winsup/cygserver/threaded_queue.cc |  4 ----
>  winsup/cygwin/fhandler_dsp.cc      |  4 ++--
>  winsup/cygwin/path.cc              |  2 +-
>  winsup/cygwin/pinfo.cc             | 16 ++++++++--------
>  winsup/cygwin/signal.cc            |  2 +-
>  6 files changed, 12 insertions(+), 19 deletions(-)

I got the copyright assignment form back, so this can now be reviewed
and hopefully merged.

Thanks,

Peter Foley


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]