This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] cygwin: update child info magic


On Feb 12 14:05, Yaakov Selkowitz wrote:
> On 2016-02-12 11:18, Corinna Vinschen wrote:
> >On Feb 12 10:53, Yaakov Selkowitz wrote:
> >>On 2016-02-12 03:33, Corinna Vinschen wrote:
> >>>On Feb 11 20:38, Yaakov Selkowitz wrote:
> >>>>	winsup/cygwin/
> >>>>	* child_info.h (CURR_CHILD_INFO_MAGIC): Update.
> >>>
> >>>This needs an explanation.  CHILD_INFO_MAGIC is still 0x30ea98f6U
> >>>for me.
> >>
> >>Hmmm, in that case it's either one of the patches I just sent or it's gcc-5.
> >>How would either of those affect this?
> >
> >Off the top of my head, I don't know.  Usually only a change to
> >child_info.h should affect CHILD_INFO_MAGIC.  Unless the preprocessed
> >output of gcc differs for some reason.
> 
> It turns out it does.  Anything that is substituted by preprocessor is
> placed on its own line with gcc-5, e.g. with NULL and _SYMSTR:
> 
> @@ -47340,7 +47636,11 @@
>    char filler[4];
>    child_info_fork ();
>    void __attribute__((__stdcall__)) __attribute__ ((regparm (1)))
> handle_fork ();
> -  bool abort (const char *fmt = __null, ...);
> +  bool abort (const char *fmt =
> +                               __null
> +                                   , ...);
>    void alloc_stack ();
>  };
> 
> @@ -47422,6 +47722,14 @@
> 
>  extern "C" {
>  extern child_info *child_proc_info;
> -extern child_info_spawn *spawn_info asm ("_" "child_proc_info");
> -extern child_info_fork *fork_info asm ("_" "child_proc_info");
> +extern child_info_spawn *spawn_info asm (
> +                                        "_"
> +                                        "child_proc_info");
> +extern child_info_fork *fork_info asm (
> +                                      "_"
> +                                      "child_proc_info");
>  }

Is that deliberate or a bug?


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: signature.asc
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]