This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] cygcheck -m, --check-mtimes option


Hi Christian,

On Aug  7 22:15, Christian Franke wrote:
> Attached is an experimental patch which adds -m, --check-mtimes[=SECONDS]
> option to cygcheck. It provides an IMO useful heuristics to find files
> possibly modified after installation.
> 
> "cygcheck -c -m" prints the number of files with st_mtime >
> INSTALL_TIME+SECONDS. INSTALL_TIME is the st_mtime of the
> /etc/setup/PACKAGE.lst.gz file.
> 
> With -v, the affected path names are printed. The optional parameter SECONDS
> defaults to 600 to hide files modified by postinstall scripts.

That's an interesting idea.  I just gave it a try.  I think this might
be useful, but from a user perspective I'm not very happy with the
presentation:

Newer file: /usr/bin/which.exe from package which (written 146 days after installation)
which                               2.20-2                 OK          (1 newer)

Three points:

- The "(1 newer)" is too far to the right.  If more than 9 files are
  newer the line gets longer than 80 chars.  To avoid collision with
  the "Incomplete" status, let's move the status 2 chars to the left,
  too.

- The verbose text should be printed after the affected package, not before.
  It's simple to see why it's printed before, but this could be worked
  around by storing the affected files in a list and printing the list
  after the non-verbose package info.

- Along these lines, the verbose "Newer file %s from package %s (...)"
  is a bit... verbose.  Assuming it gets printed after the package name,
  it might be easier on the eyes to use a simpler, indented format.
  Just as a first suggestion, what about something like:

which                               2.20-2                 OK        (1 newer)
  /usr/bin/which.exe (changed 146 days after install)

or (uh oh!):

which                               2.20-2                 OK        (1 newer)
  /usr/bin/which.exe (changed 71 days ago)

> Documentation update and changelog entry are still missing.

Sure, no worries for now.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: pgpaw4YFmbSjw.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]