This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix some debug string format specifiers.


On Dec 22 00:39, Ray Donnelly wrote:
> I hope patches generated with git are OK?

In theory, yes, but please attach them inline to the mail, otherwise
they won't show up in the reply with some mailers, so it's a hassle
to discuss them.

As for this patch, did you actually test it?

-	len = sprintf(dbuf, "[mcleanup1] kcount 0x%x ssiz %d\n",
+	len = sprintf(dbuf, "[mcleanup1] kcount 0x%p ssiz %zd\n",

%p implies printing the 0x prefix, so this results in twice the prefix.

-                       "[mcleanup2] frompc 0x%x selfpc 0x%x count %d\n" ,
+                       "[mcleanup2] frompc 0x%zd selfpc 0x%zd count %zd\n" ,

0x prefix and 'd' format specifier?


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: pgpd9xN4aYrK5.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]