This is the mail archive of the cygwin-patches mailing list for the Cygwin project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Wed, May 11, 2011 at 10:21:14AM -0400, Ryan Johnson wrote:Done. Please disregard the older (bundled) versions because I found a couple of glitches in the patches which the the 1-per-email set fixes.On 11/05/2011 10:13 AM, Christopher Faylor wrote:On Wed, May 11, 2011 at 09:59:53AM +0200, Corinna Vinschen wrote:All right. Let's try this again with the correct mailing list.On May 11 02:18, Ryan Johnson wrote:Ditto. This really needs to be broken down into easier to review chunks.Please find attached five patches [...]Oops, wrong mailing list...
Btw., it would be nice if you could create patches with the diff -p flag as well. It's not exactly essential, but IMHO it's quite a help when trying to review patches.
Another problem is this: While you provide separate patches, you don't provide separate ChangeLogs. That makes it kind of hard to apply them separately. Would you mind to create one ChangeLog per change?
The patches have been generated with diff -p, and each includes appropriate changelog entries. Hopefully the changes are split up finely enough because I don't know a good way to break them down any further.
For posterity's sake I'm including the original message body below.Please: One patch per message. One ChangeLog entry per message, not sent as a diff.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |