This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] reorder major-0 devices (was Re: [PATCH] implement /proc/sysvipc/*)


On Apr  3 16:54, Yaakov (Cygwin/X) wrote:
> On Fri, 2011-04-01 at 23:33 +0200, Corinna Vinschen wrote:
> > On Apr  1 14:57, Yaakov (Cygwin/X) wrote:
> > > For the sake of clarity, I would reorder it a bit further to
> > > make FH_PROC and friends to one side of major-0 and everything else to
> > > the other side:
> > > 
> > >   /* begin /proc directories */
> > >   FH_PROC    = FHDEV (0, 255),
> > >   FH_REGISTRY= FHDEV (0, 254),
> > >   FH_PROCNET = FHDEV (0, 253),
> > >   FH_PROCESSFD = FHDEV (0, 252),
> > >   FH_PROCSYS = FHDEV (0, 251),
> > >   FH_PROCSYSVIPC = FHDEV (0,250),
> > > 
> > >   FH_PROC_MIN_MINOR = FHDEV (0,200),
> > >   /* end /proc directories */
> > > 
> > >   FH_PIPE    = FHDEV (0, 199),
> > >   FH_PIPER   = FHDEV (0, 198),
> > >   FH_PIPEW   = FHDEV (0, 197),
> > >   FH_FIFO    = FHDEV (0, 196),
> > >   FH_PROCESS = FHDEV (0, 195),
> > >   FH_FS      = FHDEV (0, 194),	/* filesystem based device */
> > >   FH_NETDRIVE= FHDEV (0, 193),
> > >   FH_DEV     = FHDEV (0, 192),
> > > 
> > > As either way this should be a separate changeset IMHO, I have committed
> > > my patch as is and will follow this up on Sunday.
> > 
> > Sounds ok to me.
> 
> Patch attached.
> 
> 
> Yaakov
> 

> 2011-03-04  Yaakov Selkowitz  <...>
> 	    Corinna Vinschen  <...>

Bzzz.  Please, don't quote raw email addresses, not even as part of
a patch submission.  Especially don't quote my raw email address.

> 	* devices.h (fh_devices): Define FH_PROC_MIN_MINOR.
> 	Reorder major-0 devices so that all /proc directories fall
> 	between FH_PROC and FH_PROC_MIN_MINOR.
> 	* path.h (isproc_dev): Redefine accordingly.

Looks good.  Please apply.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]