This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] add get_nprocs, get_nprocs_conf


On Nov 11 15:21, Christopher Faylor wrote:
> On Wed, Nov 11, 2009 at 12:19:46PM -0600, Yaakov (Cygwin/X) wrote:
> >On 11/11/2009 06:55, Eric Blake wrote:
> >> +1 on the concept from me, although why does sys/sysinfo.h have to
> >> forward to cygwin/sysinfo.h, rather than directly declaring the two functions?
> >
> >I simply followed the pattern of many of the sys/*.h headers, and by 
> >their copyright dates are relatively newer, which redirected to a 
> >cygwin/*.h equivalent.  If there is supposed to be some rhyme and reason 
> >to which ones redirect and which ones do not, please feel free to clue 
> >me in. :-)
> 
> The only time I add a cygwin/foo.h is when newlib has a version of the
> same file and I don't feel like wildly ifdef'ing it.
> 
> It looks like Corinna has added a few of these so I guess she'll have
> to provide the r&r.

Erm... well... whenever I did that, "it seemed a good idea back then".
No, really, some of them were based on the decision that this is quite
Cygwin specific, like the mtio.h and rdevio.h files, some were the
result of ripping out Cygwin-specific stuff from newlib.  History is
probably as good a description as reason in many cases.  Having
low-level stuff in the cygwin subdirectory is still basically a good
idea, IMHO.

In this case I'm rather surprised that these very GNU/Linux specific
things are *not* in a linux/sysinfo.h file.  But it doesn't hurt to keep
that in line with Linux, right?


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]