This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [1.7] rename/renameat error


On Sep 23 10:09, Christopher Faylor wrote:
> On Wed, Sep 23, 2009 at 03:30:15PM +0200, Corinna Vinschen wrote:
> >Urgh.  I stumbled over the need_directory flag only two days ago.  while
> >debugging the symlink errno problem you reported on the list.  CGF is my
> >witness.  It's the reason I made the trailing slash change in symlink
> >rather than in path_conv::check.  It's quite tricky to keep all possible
> >cases working.  Have you tested this change with the entire coreutils
> >testsuite?  It seems to be quite thorough.
> 
> Yes, I'm a witness.  I mentioned that this has to still work:
> 
> ls -l foo/
> 
> where foo is a directory.  I think that requirement is the cause for

Actually, where foo is a symlink pointing to an existing directory.

> some complication in the code.
> 
> Do we really want to be making many changes to this code at this point
> in the release cycle?  Maybe we could branch 1.7.1 and keep making
> riskier changes on the trunk, just like the real projects do it?

Also less risky would be to make changes locally in mkdir, link, and
rename for now.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]