This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [PATCH] Libstdc++ support changes.
Christopher Faylor wrote:
> On Tue, Jul 07, 2009 at 07:18:58PM +0200, Corinna Vinschen wrote:
>> In the ChangeLogs,
>> please use just one space after the colon.
> Nope. I noticed the comment style too (and missed the two spaces after
> the colon). Obviously not a big deal but it would be nice to have them
> consistent.
All tidied up and committed. I even added missing pre-terminator spaces to
a couple of existing comments where they were in diff hunks anyway.
As you mentioned the ChangeLog thing, well I always thought of that as the
start of a sentence, not counting the file/function name which I think of as
being like the number at the start of an itemised list item. Anyway it's in
the coding standards that way, so I went back and fixed up my old entries.
Committed the attached as obvious.
cheers,
DaveK
Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/ChangeLog,v
retrieving revision 1.4560
diff -p -u -r1.4560 ChangeLog
--- ChangeLog 7 Jul 2009 20:12:44 -0000 1.4560
+++ ChangeLog 7 Jul 2009 20:24:08 -0000
@@ -116,7 +116,7 @@
2009-07-04 Dave Korn <dave.korn.cygwin@gmail.com>
- * autoload.cc (AttachConsole): Correct size of args.
+ * autoload.cc (AttachConsole): Correct size of args.
2009-07-03 Christopher Faylor <me+cygwin@cgf.cx>
@@ -495,8 +495,8 @@
2009-06-05 Dave Korn <dave.korn.cygwin@gmail.com>
- * winbase.h (ilockexch): Fix asm constraints.
- (ilockcmpexch): Likewise.
+ * winbase.h (ilockexch): Fix asm constraints.
+ (ilockcmpexch): Likewise.
2009-06-05 Corinna Vinschen <corinna@vinschen.de>
@@ -523,8 +523,8 @@
2009-06-04 Dave Korn <dave.korn.cygwin@gmail.com>
- * thread.cc (__cygwin_lock_lock): Delete racy optimisation.
- (__cygwin_lock_unlock): Likewise.
+ * thread.cc (__cygwin_lock_lock): Delete racy optimisation.
+ (__cygwin_lock_unlock): Likewise.
2009-06-03 IWAMURO Motnori <deenheart@gmail.com>
@@ -857,10 +857,10 @@
2009-04-13 Dave Korn <dave.korn.cygwin@gmail.com>
- * include/stdint.h (intptr_t): Remove long from type.
- (uintptr_t): Likewise.
- (INTPTR_MIN): Remove 'L' suffix.
- (INTPTR_MAX, UINTPTR_MAX): Likewise.
+ * include/stdint.h (intptr_t): Remove long from type.
+ (uintptr_t): Likewise.
+ (INTPTR_MIN): Remove 'L' suffix.
+ (INTPTR_MAX, UINTPTR_MAX): Likewise.
2009-04-12 Christopher Faylor <me+cygwin@cgf.cx>
@@ -894,8 +894,8 @@
2009-04-11 Dave Korn <dave.korn.cygwin@googlemail.com>
- * include/stdint.h (INTPTR_MIN, INTPTR_MAX): Add 'L' suffix.
- (WINT_MAX): Add 'U' suffix.
+ * include/stdint.h (INTPTR_MIN, INTPTR_MAX): Add 'L' suffix.
+ (WINT_MAX): Add 'U' suffix.
2009-04-10 Christopher Faylor <me+cygwin@cgf.cx>