This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix type inconsistencies in stdint.h


On Sat, Apr 11, 2009 at 08:48:35PM +0100, Dave Korn wrote:
>Christopher Faylor wrote:
>
>> 
>> So the answer is "int".
>
>
>  Oh, drat.  Yes, shoulda changed the type, not the constant.  Gah.  Like
>this, you mean?
>
>
>winsup/cygwin/ChangeLog
>
>	* include/stdint.h (intptr_t):  Remove long from type.
>	(uintptr_t):  Likewise.
>	(INTPTR_MIN):  Remove 'L' suffix.
>	(INTPTR_MAX, UINTPTR_MAX):  Likewise.
>
>
>    cheers,
>      DaveK

>Index: stdint.h
>===================================================================
>RCS file: /cvs/src/src/winsup/cygwin/include/stdint.h,v
>retrieving revision 1.12
>diff -p -u -r1.12 stdint.h
>--- stdint.h	11 Apr 2009 08:07:30 -0000	1.12
>+++ stdint.h	11 Apr 2009 19:35:11 -0000
>@@ -57,9 +57,9 @@ typedef unsigned long long uint_fast64_t
> 
> #ifndef __intptr_t_defined
> #define __intptr_t_defined
>-typedef long intptr_t;
>+typedef int intptr_t;
> #endif
>-typedef unsigned long uintptr_t;
>+typedef unsigned int uintptr_t;
> 
> /* Greatest-width integer types */
> 
>@@ -119,9 +119,9 @@ typedef unsigned long long uintmax_t;
> 
> /* Limits of integer types capable of holding object pointers */
> 
>-#define INTPTR_MIN (-2147483647L - 1L)
>-#define INTPTR_MAX (2147483647L)
>-#define UINTPTR_MAX (4294967295UL)
>+#define INTPTR_MIN (-2147483647 - 1)
>+#define INTPTR_MAX (2147483647)
>+#define UINTPTR_MAX (4294967295U)
> 
> /* Limits of greatest-width integer types */

I thought I responded to this but I must have imagined it.

Yes, I think this is right.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]