This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Correctly compute whether the process is a non-Cygwin process in spawn_guts


On Thu, 5 Jan 2006, Christopher Faylor wrote:

> On Thu, Jan 05, 2006 at 09:46:46AM -0500, Igor Peshansky wrote:
> >The attached patch fixes the "no output from commands invoked through
> >ssh" for me.  The ChangeLog is below.
> >	Igor
> >==============================================================================
> >2006-01-05  Igor Peshansky  <pechtcha@cs.nyu.edu>
> >
> >	* spawn.cc (spawn_guts): Invert the argument to
> >	set_console_state_for_spawn.
>
> Did you happen to notice the name of the argument to
> "set_console_state_for_spawn"?

Yes, I did.  It's supposed to be true for a non-Cygwin process and false
for a Cygwin process.  IIUC, my patch makes it so.

> Sorry, but this seems to be a "fix the symptom" patch.
>
> Apparently iscygexec is getting set incorrectly.  That is probably the
> problem.

I may be misunderstanding what iscygexec() does.  I thought it was true if
the process was a Cygwin process, in which case my patch actually fixes
the problem, not the symptom...
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_	    pechtcha@cs.nyu.edu | igor@watson.ibm.com
ZZZzz /,`.-'`'    -.  ;-;;,_		Igor Peshansky, Ph.D. (name changed!)
     |,4-  ) )-,_. ,\ (  `'-'		old name: Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte."
"But no -- you are no fool; you call yourself a fool, there's proof enough in
that!" -- Rostand, "Cyrano de Bergerac"


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]