This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [PATCH] Re: IP_MULTICAST_IF et all / Winsock[2] value conflict
- From: Corinna Vinschen <corinna-cygwin at cygwin dot com>
- To: cygwin-patches at cygwin dot com
- Date: Mon, 17 Oct 2005 23:26:39 +0200
- Subject: Re: [PATCH] Re: IP_MULTICAST_IF et all / Winsock[2] value conflict
- References: <Pine.CYG.4.58.0509291103421.2244@PC1163-8460-XP.flightsafety.com> <20050929165053.GU12256@calimero.vinschen.de> <Pine.CYG.4.58.0509291152490.2244@PC1163-8460-XP.flightsafety.com> <20050930081701.GB27423@calimero.vinschen.de> <Pine.CYG.4.58.0509300947210.2244@PC1163-8460-XP.flightsafety.com> <20050930200048.GE12256@calimero.vinschen.de> <Pine.CYG.4.58.0509301817260.1904@PC1163-8460-XP.flightsafety.com> <20051003165358.GA4436@calimero.vinschen.de> <Pine.CYG.4.58.0510031213250.1904@PC1163-8460-XP.flightsafety.com>
- Reply-to: cygwin-patches at cygwin dot com
On Oct 3 12:25, Brian Ford wrote:
> On Mon, 3 Oct 2005, Corinna Vinschen wrote:
>
> > On Sep 30 18:39, Brian Ford wrote:
> > > On Fri, 30 Sep 2005, Corinna Vinschen wrote:
> > > > Actually we have two states, applications built before we changed the
> > > > header file and applications built after we changed the header file.
> > >
> > > Let's just not change it ;-).
> >
> > No, let's change it. Winsock2 is the way to go. Winsock1 is just old
> > stuff. Since Cygwin is using Winsock2 when running on a 98 system or
> > above, and since applications using the old/wrong Winsock1 values are
> > broken right now anyway, there's no gain to keep the old values and
> > force all new (and supposed to be working) applications to go through
> > a translation stage. Let the old applications suffer, not the new ones.
>
> That's a reasonably convincing argument. I just wish fixing this didn't
> require an application recompile. I didn't think that was the Cygwin
> philosophy...<time passes> Oh, you mean do the translation only for older
> apps? That sounds good.
I've just applied a patch, which does all of that, removing the last remains
of Winsock1 support, as well as changing the IPPROTO_IP values in
include/cygwin/socket.h to the new Winsock2 values, as well as checking
for the applications ABI version number so that older applications get
the values translated into the new Winsock2 values in setsockopt/getsockopt
on the fly.
This still needs some testing.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com
Red Hat, Inc.