This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: [Patch]: tty's on Terminal Services
- From: Christopher Faylor <cgf-no-personal-reply-please at cygwin dot com>
- To: cygwin-patches at cygwin dot com
- Date: Tue, 11 May 2004 20:56:43 -0400
- Subject: Re: [Patch]: tty's on Terminal Services
- References: <3.0.5.32.20040511192134.007d4950@incoming.verizon.net>
- Reply-to: cygwin-patches at cygwin dot com
On Tue, May 11, 2004 at 07:21:34PM -0400, Pierre A. Humblet wrote:
>This patch allows the use of tty's from privileged
>accounts on Terminal Services.
What's your feeling for the dangerousness of this patch? It looks very
reasonable (in fact it looks like a "DUH"). Do you think it's safe
to include given that 1.5.10 is imminent?
If so, please check in.
cgf
>2004-05-12 Pierre Humblet <pierre.humblet@ieee.org>
>
> * tty.h: Remove the %d or %x from all cygtty strings.
> (tty::open_output_mutex): Only declare.
> (tty::open_input_mutex): Ditto.
> (tty::open_mutex): New definition.
> * fhandlet_tty.cc (fhandler_tty_slave::open): Declare buf with
> size CYG_MAX_PATH and replace __small_printf calls by shared_name.
> * tty.cc (tty::create_inuse): Ditto.
> (tty::get_event): Ditto.
> (tty::common_init): Ditto.
> (tty::open_output_mutex): New method definition.
> (tty::open_input_mutex): Ditto.
> (tty::open_mutex): New method.