This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch]: Win95


On Mon, Mar 22, 2004 at 02:57:36PM -0500, Pierre A. Humblet wrote:
>
>
>Christopher Faylor wrote:
>> 
>> On Mon, Mar 22, 2004 at 09:36:36AM -0500, Pierre A. Humblet wrote:
>> >This fixes gnuchess on Win95.
>> >There is still a compiler warning, will look at it tonight.
>> >Tested on ME, 95 and NT4.0
>> >
>> >2004-03-22  Pierre Humblet <pierre.humblet@ieee.org>
>> >
>> >       * init.cc (munge_threadfunc): Handle all instances of search_for.
>> >       (prime_threads): Test threadfunc_ix[0].
>> 
>> Hmm.  So that's what it was.  Thanks for tracking this down.
>
>Can you believe that the address appears 5 times on the stack on Win95,
>twice on ME, once on NT4.0?

I noticed that it was twice on ME and always wondered if I would have to
do something like you did.  For some reason, it never occurred to me that
this would be the problem on Win95.

The other thing that always amazed me is the spurious thread creation that
occurs when a process is starting up.  WinME, at least, can start a couple
of threads before ever hitting main.

>Now that the method is stable (after 1.5.10 is released), couldn't we store
>the offsets in wincap, keeping the adaptive method as a backup in the
>unknown case? Or are there many variations?

I guess it's a possibility but the overhead should be pretty low now.

>> I've checked in a variation of this patch.  It fixes the compiler
>> warning.  Can you verify that it still works?  I'm also building a
>> snapshot.
>
>It works on NT4.0. Will test on 95 and ME this evening.
>Do you recall what caused the warning?

The for loop had something like this:

int i;
for (char **peb = ebp, i = 0;

That defined a char **i rather than using the 'int i'.

I also got rid of a goto.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]