This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: [PATCH]: 2. Thread safe stdio update
On Jan 23 12:03, Thomas Pfaff wrote:
> Corinna Vinschen wrote:
> >On Jan 22 21:48, Thomas Pfaff wrote:
> >>2004-01-22 Thomas Pfaff <tpfaff@gmx.net>
> >>
> >> * include/sys/_types.h: New file.
> >
> >
> >I'm not quite sure if that's the way to go. I'm wondering if we
> >shouldn't keep newlib's _types.h and change it like this:
> >
> > #ifdef __CYGWIN__
> > #include <cygwin/_types.h>
> > #endif
> >
> > #ifndef __CYGWIN__
> > typedef int _flock_t;
> > #endif
> >
> >Then we can create a cygwin/_types.h with the correct _flock_t definition.
> >IMHO that's cleaner than just overloading newlib's _types.h.
> >
>
> You may be right.
>
> I just followed the way it was done in newlibs linux support where a
> modified _types.h is in newlib/libc/sys/linux/sys (and it was the
> easiest way for me to test it).
>
> Will you make this change in newlibs _types.h ?
I think you should RFA it on newlib and apply the rest of the patch
when Jeff applied. But I'd like to hear from Chris first, if that
patch should go into 1.5.7 or if it should wait for a while.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Developer mailto:cygwin@cygwin.com
Red Hat, Inc.