This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: Fixing a security hole in pinfo.
- From: Christopher Faylor <cgf at redhat dot com>
- To: cygwin-patches at cygwin dot com
- Date: Thu, 11 Sep 2003 00:15:45 -0400
- Subject: Re: Fixing a security hole in pinfo.
- References: <3.0.5.32.20030911000542.00818340@incoming.verizon.net>
- Reply-to: cygwin-patches at cygwin dot com
On Thu, Sep 11, 2003 at 12:05:42AM -0400, Pierre A. Humblet wrote:
>The flag PID_MAP_RW is added in the few pinfo constructors
>that need to be write into _pinfo if it exists.
>[snip]
>diff -u -p -r1.166 exceptions.cc
>--- exceptions.cc 10 Sep 2003 17:26:12 -0000 1.166
>+++ exceptions.cc 11 Sep 2003 03:40:57 -0000
>@@ -610,7 +610,7 @@ sig_handle_tty_stop (int sig)
> its list of subprocesses. */
> if (my_parent_is_alive ())
> {
>- pinfo parent (myself->ppid);
>+ pinfo parent (myself->ppid, PID_MAP_RW);
> if (NOTSTATE (parent, PID_NOCLDSTOP))
> sig_send (parent, SIGCHLD);
> }
The above won't need to be RW when I check in my new signal changes.
(Not that there won't be other inheritance type problems)
I'm going to hold off on checking this in until 1.5.4 is released.
Otherwise, it looks ok.
cgf