This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

security.cc


Corinna,

this patch originated when fixing the sd error handling in 
get_nt_object_attribute. In the end I simplified the structure
by moving common code in a new function, get_info_from_sd,
and setting the symlink attributes in fhandler_disk_file.
Security.cc is now 30 lines shorter.

Please double check the removal of "else if (pc->issocket ())"
from fstat_helper. I think that case has already been handled before.

Pierre

2003-04-10  Pierre Humblet  <pierre dot humblet at ieee dot org>

	* security.cc (get_info_from_sd): New function.
	(get_nt_attribute): Only call read_sd and get_info_from_sd.
	Return void.
	(get_file_attribute): Move sd error handling to get_info_from_sd.
	and symlink handling to fhandler_disk_file::fstat_helper.
	(get_nt_object_attribute): Only call read_sd and get_info_from_sd.
	Return void.
	(get_object_attribute): Remove symlink handling and simply return -1
	when ntsec is off.
	* fhandler_disk_file.cc (fhandler_disk_file::fstat_helper): For symlinks
	set the attribute, call get_file_attribute to get the ids and return. 
	In the normal case call get_file_attribute with the addresses of the buffer
	ids and do not recheck if the file is a socket.
	

Attachment: security.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]