This is the mail archive of the
mailing list for the Cygwin project.
Re: Where to put my basename() and dirname() implementation...
- From: Christopher Faylor <cgf at redhat dot com>
- To: cygwin-patches at cygwin dot com
- Date: Wed, 15 Jan 2003 13:30:34 -0500
- Subject: Re: Where to put my basename() and dirname() implementation...
- References: <59A835EDCDDBEB46BC75402F4604D5528F75D6@elmer> <009201c2bcc0$82411040$305886d9@webdev>
- Reply-to: cygwin-patches at cygwin dot com
On Wed, Jan 15, 2003 at 06:04:06PM -0000, Elfyn McBratney wrote:
>Doooh! Thanks for the heads up Sergey. It kinda seems pointless just adding
>a dirname() function but what the hell... Any inkling where i should put
>this lone sub?
I don't want to add any more libiberty routines to cygwin since the
licensing is suspect. So, please follow the normal submission rules.
Probably miscfuncs.cc is the place to add this.
>----- Original Message -----
>From: "Sergey Okhapkin" <firstname.lastname@example.org>
>To: "'Elfyn McBratney'" <email@example.com>;
>Sent: Wednesday, January 15, 2003 5:56 PM
>Subject: RE: Where to put my basename() and dirname() implementation...
>> Basename() is implemented in libiberty already, just modify cygwin.din
>> > -----Original Message-----
>> > From: firstname.lastname@example.org
>> > [mailto:email@example.com] On Behalf Of Elfyn McBratney
>> > Sent: Wednesday, January 15, 2003 12:37 PM
>> > To: firstname.lastname@example.org
>> > Subject: Where to put my basename() and dirname() implementation...
>> > I have finished my basename() and dirname() (so long for
>> > something so simple
>> > ;-) implementation and I have two questions:
>> > 1) Where would be the best place to put these functions? I
>> > was thinking dir.cc or path.cc?
>> > 2) What header file (winsup/cygwin/include) should I put the
>> > prototypes into? On my sun and redhat box they're in libgen.h
>> > so should I follow this convention?
>> > Once I have these answered I will submit the patch here.
>> > Elfyn
>> > email@example.com