This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: [PATCH] fhandler_tty read_retval fix
- From: Christopher Faylor <cgf at redhat dot com>
- To: cygwin-patches at cygwin dot com
- Date: Sat, 30 Nov 2002 17:26:03 -0500
- Subject: Re: [PATCH] fhandler_tty read_retval fix
- References: <20021129200410.A20532@eris.io.com>
- Reply-to: cygwin-patches at cygwin dot com
On Fri, Nov 29, 2002 at 08:04:10PM -0600, Steve O wrote:
>This patch fixes a premature EOF if the tty_slave happens to
>read read_retval as the pty_master is executing accept_input.
I think this one needs at least three years of testing before it
can go in.
.
.
.
Just kidding. :-)
Applied.
Thanks,
cgf
P.S. Btw, did you notice that the return value for accept_input
is not being used, AFAICT? I had always wanted to do something
with that but it never seemed to be necessary.
>ChangeLog entry
>2002-11-29 Steve O <bub@io.com>
>
> * fhandler_tty.cc (fhandler_pty_master::accept_input): Moved
> read_retval assignment to prevent race condition. Removed
> read_retval from return statement.