This is the mail archive of the
mailing list for the Cygwin project.
Re: Patch to pass file descriptors
- From: "Conrad Scott" <Conrad dot Scott at dsl dot pipex dot com>
- To: <cygwin-patches at cygwin dot com>
- Date: Mon, 1 Jul 2002 23:23:35 +0100
- Subject: Re: Patch to pass file descriptors
- References: <Pine.LNX.4.33.0207011735010.2716-100000@this>
"David Euresti" <davie@MIT.EDU> wrote:
> There's the option of keeping full BSD semantics if the
> is running. I like that. I can require users to run the cygserver.
> don't mind. [snip]
> The question is, can you incorporate my code and then you
> deal with the case when the cygserver isn't running? [snip]
> I'm sure other people will want full BSD semantics also so
> allow them to have it if the cygserver is running.
This seems to be the "standard" approach for this sort of issue (if
one example suffices to set a standard): the fhandler_tty code uses
cygserver to dup handles if available, otherwise falls back to doing
it locally; see the fhandler_tty_slave::open method in
"fhandler_tty.cc". So I don't see a problem with that.
> Unfortunately the whole net.cc has been refactored so I'll
> regenerate my patch.
Unless anyone has any objection, if you send this to the list, I'll
put it into the cygwin_daemon branch. It's not a complete or final
solution (as you've noted), and perhaps you ought to follow the
example, from the fhandler_tty.cc code, of putting some conditions
around calling cygserver, leaving a blank spot to be filled in with
the non-cygserver code. When/if such non-cygserver code appears on
HEAD I can merge it into the branch by slotting it into those blanks.