This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] File type auto-recognition


On Wed, 2001-11-07 at 00:42, Warren Young wrote:
> Attached are several new files to be added to the cinstall directory for
> the auto file type recognition stuff.  Also attached is a new version of
...

> In doing this work, I noticed that the "tar_auto" mechanism isn't used
> by any of the code.  This is pretty complicated code, so if no one has
> plans to use it, all the ifdef 0'd sections I've marked should be diked
> out to avoid confusing future spelunkers.  There are also several single
> lines commented with a //! prefix that should also be axed.

Agreed.
 
> This patch doesn't do all the nio-* refactoring that I also discussed. 
> It's just a pretty version of the first patch I did.  What with recent
> comments by Robert and Chuck, I figured I needed to ship _something_. 
> (My day job has been a bear lately...)
> 

I'll have a good look at this tomorrow.

I'm putting the finishing touches on the grand refactored stuff now,
barring:
* the http class
* the bz2 class

but including

* the file and cygfile classes
* archive and compress classes
* tar class.

I *have* made major functionality changes, from a coders perspective.
>From a user perspective the only thing of interest just now is that the
install.cc will handle bz2/gz and tar via the file magic and a simple
test for decompression failure.

Warren - if we can collaborate on this, I'd really like to do that. I
suspect that picking up what I've got and taking it further will be
easiest long term - but please comment on the code I've put forward
first.

I'm happy to give you a tarball of my sandbox, rather than flooding the
list again :}.

Rob


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]