This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] setup.exe & different archives for the same version ofthe app


On Sat, 2001-11-03 at 01:32, Pavel Tsekov wrote:
> Robert Collins wrote:
> > 

> > Granted. I just have no motivation to fix it, but if you have the time,
> > or someone else does, I won't object to patches that address this
> > cleanly.
>  
> See the applied patch :) Hope this will fix the problem :)

Thank you. If you could, for future patchs, have all the diffs in a
single .patch file. This makes extracting it from email and applying
earlier. (Hey, a little lziness isn't always bad).

It's customary when submitting a changelog to include the first line:

2001-11-03  Pavel Tsekov  <ptsekov@syntrex.com>

> * install.cc (install_one): Checks for the existence of the tarball
> based on a set
> of well-known package extensions.
> * filemanip.h (known_file_types): Declaration of a new global variable,
> containing
> a set of known file extensions for packages handled by setup.exe.
> * choose.cc (known_file_types): A new global variable, containing a set
> of known
> file extensions for packages handled by setup.exe

These shouldn't go into choose.cc  (choose.cc is file extension blind,
it's only concerned with packages and categories).

I've moved the array into install.cc, and accordingly made it a static
variable.

This may be part of a long term solution, related to setup accurately
knowing what files exist, but for now I'm only committing it to the
categories branch. I'd like to think that once we have file-magic based
streams that any packages that have transitioned without bumping the
suffix will have dropped off due to newer version.

Thanks again,
Rob


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]