This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: winsup/cinstall/desktop.cc: link to rxvt instead of cygwin.bat


Michael Hoffman wrote:
> 
> This is a patch to change setup so desktop and Start Menu shortcuts will
> link to rxvt instead of cygwin.bat, only if rxvt is installed.
> Otherwise, it will link to bash --login -i. It still creates cygwin.bat
> and doesn't rewrite existing shortcuts, in case people still want to use
> the batch file. Changing from cygwin.bat to bash --login -i was
> suggested more than a year ago and DJ said "Patches welcome," so here is
> the patch. :-)
> 
> http://sources.redhat.com/ml/cygwin/2000-08/msg00514.html
> 
> Since the shortcuts no longer link to a batch file, I don't think the
> code in make_link that constructs a command line for Win9X should be
> necessary. But I don't have a Win9X system to test on, so I left it
> alone.
> 
> Please let me know if you have any thoughts about this.
> 

I don't like your choice of values for the rxvt switches.  It doesn't
matter what you change them to I'll never like your choice of switches. 
Given that you should modify your patch to create a cygwin-rxvt.bat file
and use that if rxvt is available.  Then I can modify your choice of
switches like I'm used to changing other values.  Shortcutting directly
to the executable doesn't allow me to add environment variables such as
CYGWIN before starting the process.  Shortcutting to a bat file is a
common Cygwin occurrence that if it doesn't happen will generate
hundreds to thousands of list mail.

Earnie.

_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]