Re: charset changes

[Corinna Vinschen <corinna-cygwin at cygwin dot com>]

On Jan 23 11:05, Andy Koppe wrote:
> I'm in awe at Corinna's latest locale changes. Getting closer and
> closer to the real thing.

Thanks, I'm quite happy with it.

> A couple of points:
> - With TIS-620 now being returned as the nl_langinfo name for the Thai
> codepage CP874, I think it should also be recognised as a charset name
> by setlocale(). A Google search shows that both th_TH.TIS620 and
> th_TH.TIS-620 are in use, so perhaps best to add both. Shall I send a
> newlib patch?

No worries.  I'll add it to the Cygwin-only part of loadlocale.

> - Not a new issue, but is there any point in accepting JIS as a
> character set name, given that it isn't actually implemented?

It's still supported by newlib itself.  What we could do is to disable
it in loadlocale explicitely for Cygwin.

> And a complete nitpick: __set_charset_from_locale has lots of separate
> calls to strcpy to set the charset. These could be consolidated by
> assigning the charset name to a local variable and copying it in one
> place.

Sure, but in how far is that better or faster, given that this is
a one-liner?


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat