This is the mail archive of the
cygwin-developers@cygwin.com
mailing list for the Cygwin project.
changes to fhandler_process.cc from 02/06/2002 should be reverted
- From: "Chris January" <chris at atomice dot net>
- To: <cygwin-developers at cygwin dot com>
- Date: Sun, 30 Jun 2002 14:00:26 +0100
- Subject: changes to fhandler_process.cc from 02/06/2002 should be reverted
I've just seen this ChangeLog entry, Chris:
2002-06-02 Christopher Faylor <cgf@redhat.com>
Remove unneeded sigproc.h includes throughout.
* fhandler.h (fhandler_proc::fill_filebuf): Take a pinfo argument.
* fhandler_proc.cc (fhandler_proc::get_proc_fhandler): Simplify search
for given pid.
(fhandler_proc::readdir): Assume that pid exists if it shows up in the
winpid list.
* fhandler_process.cc (fhandler_process::open): Simplify search for
given pid. Call fill_filebuf with pinfo argument.
(fhandler_process::fill_filebuf): Pass pinfo here and assume that it
exists.
* pinfo.h (pinfo::remember): Define differently if sigproc.h is not
included.
IMHO, these changes need to be reverted. fhandler_base::fill_filebuf is
virtual. If you add the pinfo parameter to fhandler_process::fill_filebuf,
then you are defining a new function, not overriding the one in
fhandler_base. Hence, /proc semantics whereby the file contents are
refreshed on an lseek are broken.
Regards
Chris