This is the mail archive of the cygwin-developers@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Added some defensive code to net/socket functions

[Get raw message]
On Fri, Nov 23, 2001 at 10:18:35PM -0500, Christopher Faylor wrote:
> As I was in the process of adding the fd protection code that was just
> mentioned in the cygwin mailing list, I decided to add the normal buffer
> checking defensive code to most of the net/socket functions.  I've
> verified that sshd, inetd, and telnetd still work, but I'd appreciate it
> if I could get some assurance that I haven't broken anything else.
> 
> The checking in net.cc was a lot trickier than I had anticipated so
> I could easily have gotten something wrong.
> 
> If someone could verify my changes, it would be great.

They look ok except for one in cygwin_inet_network() which I've just
changed.

I have added the missing checks except for cygwin_rcmd() and
cygwin_rexec().  They both have a so weird usage of the pointered
parameters.  Hmm, I could add stuff at least partly.

Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin@cygwin.com
Red Hat, Inc.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]