This is the mail archive of the cygwin-developers@sources.redhat.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: cygcheck patch



> From: Matt <matt@use.net>

> Changelog:

Your patch is OK, but please format your Changelog Entry like all the
rest.  Specifically, you don't disclose your full name, which is part
of the ChangeLog, entries are indented with a tab, proper
capitalization and punctuation is needed, you don't repeat the
filename for multiple changes therein, and do include the function
names.  Example:

2000-12-07  Matt Someone  <matt@use.net>

	* utils/cygcheck.cc (keyeprint): Moved declaration before
	other functions so it could be used by all functions to report
	error messages.
	(add_path): Check for NULL.
	(find_on_path): Ditto.
	(init_paths): Check for errors.
	(track_down): Ditto, plus NULL.  Close memory leak.

(etc)

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]