Re: ntsec-patch16 (and some other)

[Chris Faylor <cgf at cygnus dot com>]

On Sat, Jan 08, 2000 at 09:19:41PM +0100, Corinna Vinschen wrote:
>Chris Faylor wrote:
>> On Sat, Jan 08, 2000 at 08:03:41PM +0100, Corinna Vinschen wrote:
>> >[...]
>> >- configure: I had to add the directory `mingw/profile'
>> >  else it was ignored.
>> 
>> This can't be right.  The profile directory should be handled by mingw's
>> configure.  The "top level" configure is only supposed to handle
>> directories immediately below it.
>
>That's curious, because on the other hand a `make' in the winsup dir
>want to `make all' in mingw/profile which then failes because there's
>no Makefile...

Are you sure?  I don't see how the winsup Makefile could possibly
be doing anything in mingw/profile.  Do you actually see the string
"mingw/profile" in winsup/Makefile?  The only place I would expect
to see this is in winsup/mingw/Makefile.

>> >- cygwin/smallprintf.c: I had to add `#define __INSIDE_CYGWIN__'
>> >  else the linker said sth. about `undef'd ref to _ctype_'.
>> >
>> >- cygwin/regexp/regexp.c: Ditto.
>> 
>> These are supposed to be handled already.  It obviously isn't required
>> all the time or we wouldn't be able to make snapshots.
>
>I was astonished, too, because the sources are exactly
>the same. The _only_ difference I saw:
>
>In the previous snapshots the compiler got the flag
>`-D__INSIDE_CYGWIN__' as well. This is not the case
>in the latest snapshot.

Well, then, that is the problem to fix.  I have done so in our sources.

cgf