This is the mail archive of the cygwin-developers@sourceware.cygnus.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: (patch) winsup noncygwin mess cleanup


On Sat, Dec 04, 1999 at 08:03:07PM -0600, Mumit Khan wrote:
>Here's a patch to current CVS tree to remove the gross hack that was
>there to load Cygwin DLL from a noncygwin app (eg., Java JNI, etc).

This is wicked cool!  Thank you!

Can I just make one minor stylistic suggestion?

I think I'd prefer just using the "dynamically_loaded" variable
directly rather than using the NON_CYGWIN_APP macro.  I think
that the "dynamically_loaded" variable is clearer, especially
when it is negated:

	if (!dynamically_loaded)
	  .
	  .
	  .

Otherwise, this all looks perfect.

cgf

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]