This is the mail archive of the
cygwin-developers@sourceware.cygnus.com
mailing list for the Cygwin project.
Re: Patch: error in fhandler_base read/write code
- To: cygdev <cygwin-developers@sourceware.cygnus.com>
- Subject: Re: Patch: error in fhandler_base read/write code
- From: Chris Faylor <cgf@cygnus.com>
- Date: Sun, 15 Aug 1999 18:27:31 -0400
- References: <37B49BBB.CD2A1D9A@vinschen.de>
- Reply-To: cygwin-developers@sourceware.cygnus.com
Applied. Thanks.
-chris
On Sat, Aug 14, 1999 at 12:27:07AM +0200, Corinna Vinschen wrote:
>I have found two errors in fhandler code:
>- In case of an error fhandler_base::raw_read always returns the error
> code EACCES.
>- fhandler_base::raw_write always returns bytes_written if the windows
> error is ERROR_DISK_FULL. This results in an endless loop e.g. in
> cp command if bytes_written is 0.
>
>While changing the above behaviour I found that ERROR_DISK_FULL is
>not handled by errno.cc.
>
>ChangeLog:
>==========
>
>Sat Aug 14 0:10:00 Corinna Vinschen <corinna@vinschen.de>
>
> * fhandler.cc (fhandler_base::raw_read): `set_errno (EACCES)'
> replaced with `__seterrno_from_win_error (errcode)'.
> (fhandler_base::raw_write): In case of ERROR_DISK_FULL, return
> bytes_written only if bytes_written > 0.
> * errno.cc: Map ERROR_DISK_FULL to ENOSPC.
>[snip]