Re: [PATCH setup] Make sure that fatal error messages are visible

[Ken Brown <kbrown at cornell dot edu>]

On 12/20/2017 11:19 AM, Jon Turney wrote:
> On 19/12/2017 00:53, Ken Brown wrote:
> > The message box produced by TOPLEVEL_CATCH could be hidden by whatever
> > window was previously being displayed, so that setup appeared to hang.
> > Fix this by giving fatal error message boxes type MB_SETFOREGROUND.
>
> This is good as far as it goes, but is kind of working around the fact 
> that fatal() is being called with an NULL owner HWND.
>
> This is not idea because I guess it means that propsheet window is still 
> activate-able when this messagebox is displayed (MB_APPMODAL doesn't 
> apply)?

It turns out that MB_SYSTEMMODAL did the job.  I tried MB_APPLMODAL and 
MB_TASKMODAL also, but both of those still allowed me to activate the 
propsheet window.

Revised patch attached.

Ken

Attachment: 0001-Make-sure-that-fatal-error-messages-are-visible.patch
Description: Text document