This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH setup 0/2] Improve behavior after download error


This is a followup to
https://sourceware.org/ml/cygwin-apps/2017-11/msg00003.html.  The
focus of that thread was a crash that occurs on the topic/libsolv
branch.  Here I'm more interested in a UI issue.  Namely, I don't
think it's reasonable that setup goes back to the site page if the
user clicks Yes in response to "Download Incomplete. Try again?".
This is not what the message says will happen, and I'm not convinced
that it even works right if the user changes mirrors after being sent
to the site page.

The first patch in this series instead puts the relevant code in a
retry loop.  This should require indentation of a large amount of
code.  To keep the patch readable, I've saved the indentation for a
separate patch.

Ken Brown (2):
  Improve behavior after download error
  Whitespace fixes

 download.cc | 161 ++++++++++++++++++++++++++++++++----------------------------
 res.rc      |   1 +
 resource.h  |   1 +
 3 files changed, 88 insertions(+), 75 deletions(-)

-- 
2.15.0


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]