This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: calm: mksetupini doesn't allow non-empty source but empty install files for an obsolete package
- From: Jon Turney <jon dot turney at dronecode dot org dot uk>
- To: cygwin-apps at cygwin dot com
- Cc: Ken Brown <kbrown at cornell dot edu>
- Date: Tue, 23 May 2017 17:55:06 +0100
- Subject: Re: calm: mksetupini doesn't allow non-empty source but empty install files for an obsolete package
- Authentication-results: sourceware.org; auth=none
- References: <6c13643f-5005-9629-77f7-f34f48b60f3e@cornell.edu>
On 23/05/2017 14:44, Ken Brown wrote:
I've created an obsolete package (as discussed starting at https://sourceware.org/ml/cygwin-apps/2017-05/msg00084.html). But mksetupini doesn't like it:
mksetupini: package 'texlive-collection-htmlxml' version '20170520-1' source has no non-empty install tarfiles
mksetupini: package set has errors, not writing setup.ini
I thought the following would fix it:
--- a/calm/package.py
+++ b/calm/package.py
@@ -636,6 +636,9 @@ def validate_packages(args, packages):
if packages[p].tars[packages[p].vermap[v]['source']].is_empty:
continue
This should be being caught by this case (source is empty), but it
isn't, I guess because it's got a .keep file due to other problems
previously discussed.
+ if '_obsolete' in packages[p].vermap[v].get('category', ''):
+ continue
I think this maybe needs to be
packages[p].version_hints[v].get('category', '') ?
+
if not packages[p].tars[packages[p].vermap[v]['source']].is_used:
logging.error("package '%s' version '%s' source has no non-empty install tarfiles" % (p, v))
error = True
But I must have something wrong, because I still get the error after this change.