Re: [ITP] libsass v3.3.6

[Marco Atzeri <marco dot atzeri at gmail dot com>]

On 07/06/2016 11:49, Achim Gratz wrote:
> Marcos Vives Del Sol <socram8888@...> writes:
> > This script is called using m4_esyscmd_s from configure.ac line 6:
> > -----------------
> > AC_INIT([libsass], m4_esyscmd_s([./version.sh]), [support@...])
> > -----------------
> > to set the library version at compile time. Then configure uses it to
> > generate the version.h file.
>
> Make a patch for configure.ac and add it to PATCH_URI, then.  That will
> patch in origsrc/ and hence not produce a libsass.src.patch file later on.
>
> Based on the way configure is supposed to be working it seems that either
> the tarball you're using is incomplete (did you use a Git snapshot?) or they
> forgot to package the VERSION file.
>
>
> Regards,
> Achim.

in an case Marcos the patch is not doing what
you think it should do.

------------------------------------------------------------
$ cat libsass-3.3.6-1.src.patch
--- origsrc/libsass-3.3.6/VERSION       1970-01-01 01:00:00.000000000 +0100
+++ src/libsass-3.3.6/VERSION   2016-06-02 16:25:17.016583300 +0200
@@ -0,0 +1 @@
+3.3.6
------------------------------------------------------------

As VERSION doesn't exist is is not created in the
src root (libsass-3.3.6-1.x86_64/src/libsass-3.3.6)
but two level upper:

$ find libsass-3.3.6-1.x86_64 -name VERSION
libsass-3.3.6-1.x86_64/src/libsass-3.3.6/src/libsass-3.3.6/VERSION

It is a side unwanted effect of the smart patching.
If you want to create it, you should rewrite it as:

------------------------------------------------------------
$ cat libsass-VERSION.patch
--- VERSION       1970-01-01 01:00:00.000000000 +0100
+++ VERSION   2016-06-02 16:25:17.016583300 +0200
@@ -0,0 +1 @@
+3.3.6
------------------------------------------------------------

and define PATCH_URI="libsass-VERSION.patch"

Regards
Marco