Re: [Attn Maintainer] git git-svn

[Adam Dinwoodie <adam at dinwoodie dot org>]

On Sun, Aug 02, 2015 at 08:35:25AM +0200, Achim Gratz wrote:
> The tests for 2.5.0 just completed:
> 
> --8<---------------cut here---------------start------------->8---
> fixed   1
> success 12528
> failed  0
> broken  179
> total   12808
> --8<---------------cut here---------------end--------------->8---
> 
> âon both architectures.  I do not have cvs installed, so those tests (as
> well as Perforce) have not run.

I'm going to continue to be cautious: while I think the risk of bumping
up to v2.5.0 is very low, if there are problems with that or any of the
other numerous recent changes (this has been the first time a release
has got above the -1 version since I took over maintainership), I want
to keep the changes reasonably slow to help narrow down where the
problem comes from.

> A few suggestions for changes to the cygport:
> 
> --8<---------------cut here---------------start------------->8---
> SRC_URI="https://git.kernel.org/cgit/git/git.git/snapshot/${PN}-v${PV}.tar.gz";
> SRC_DIR="${PN}-v${PV}"
> --8<---------------cut here---------------end--------------->8---
> 
> Then not "inherit git", a snapshot is less wasteful then the cloning
> unless you plan to really work with the repository which cygport makes
> difficult anyway.

Done.  I switched from something similar when I took over the
maintainership, as using "inherit git" seemed like The Right Thing To Do
when I was first playing around with Cygport.  As you say, though, it's
just adding overhead with no advantage.  (Indeed if I want to play
around with the Git repository itself, I already have a copy of that
ready to go.)


> --8<---------------cut here---------------start------------->8---
> [[ $ARCH_x86_64 ]] && DEPEND="$DEPEND libiconv libiconv-devel"
> --8<---------------cut here---------------end--------------->8---
> 
> Drop this line and add libiconv, libiconv-devel plus dblatex to the
> DEPENDS unconditionally.

I'm sure when I first added that line, it made sense with the
dependencies.  I've made this change as well now, though, as it seems to
be the right thing to do at this point.

Thanks!

Adam