This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: setup
- From: Achim Gratz <Stromeko at nexgo dot de>
- To: cygwin-apps at cygwin dot com
- Date: Wed, 24 Jun 2015 22:00:24 +0200
- Subject: Re: setup
- Authentication-results: sourceware.org; auth=none
- References: <878ubtor9g dot fsf at Rainer dot invalid> <20150609095604 dot GA4993 at calimero dot vinschen dot de> <874mmghlf8 dot fsf at Rainer dot invalid> <20150610080526 dot GC31537 at calimero dot vinschen dot de> <871thjtq0m dot fsf at Rainer dot invalid> <20150610185417 dot GL31537 at calimero dot vinschen dot de> <87wpzbs2yj dot fsf at Rainer dot invalid> <87mw060xg3 dot fsf at Rainer dot invalid> <20150612102945 dot GS31537 at calimero dot vinschen dot de> <87bngkzwki dot fsf at Rainer dot invalid> <20150612173704 dot GB28638 at calimero dot vinschen dot de>
Corinna Vinschen writes:
>> What's the expected directory structure here?
>
> In the usual case ("Install from Internet") the local package directory
> contains a separate subdir for each mirror chosen from the mirror dialog:
>
> Local package directory
> |
> +-> Mirror1 subdir
> | |
> | +-> x86
> | | |
> | | +-> setup.ini
> | |
> | +-> x86_64
> | |
> | +-> setup.ini
> |
> +-> Mirror2 subdir
> | |
> | +-> x86
> | | |
> | | +-> setup.ini
> | |
> | +-> x86_64
> | |
> | +-> setup.ini
> .
> .
> .
I've looked at what the original code was doing (or what I think it was
doing). Besides the case that you show, it would also find a setup.ini
if the local directory was set one or two levels down (into the mirror
level or the architectire subtree level, respectively). In the latter
case, the local directory was required to have its last component the
correct architecture. I think I have cooked up a solution to do this
(not yet fully implemented nor tested), but the code would be cleaner if
the local package directory would never be at the same level where
setup.ini resides (which necessitates to extract the last path component
and check for the correct architecture).
So the question is if that was maybe an accidental feature that can be
removed? The code would become a bit cleaner. If anybody was using it
inadvertently, they just need to remove that last component form the
local package directory, so there's no loss of functionality that I can
see.
There's another accidental feature (I think) in that old code in that
you could mix two package sources at different levels like this:
> Local package directory (ending in /x86)
> |
> +-> Mirror1 subdir
> | |
> | +-> x86
> | | |
> | | +-> setup.ini
> | |
> | +-> x86_64
> | |
> | +-> setup.ini
> +-> x86
> | |
> | +-> setup.ini
> |
> +-> setup.ini
and setup-x86.exe would find three setup.ini. I think that's a mistake
and I would want to truncate the search at the first level a setup.ini
has been found (in this example only the one in the local package
directory).
Regards,
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
SD adaptation for Waldorf microQ V2.22R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada