This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH setup 4/4] Silently ignore 'x' and 'g' type tar extended headers


On Mar 10 15:23, Jon TURNEY wrote:
> On 10/03/2015 14:23, Corinna Vinschen wrote:
> >On Mar 10 14:01, Jon TURNEY wrote:
> >>On 06/03/2015 06:08, Achim Gratz wrote:
> >>>Jon TURNEY writes:
> >>>>It seems that base-files has an 'x' extended header for each file, apparently to
> >>>>store the mtime.
> >>>
> >>>That's a result of me having built that file on openSUSE and openSUSE's
> >>>decision to default to POSIX format instead of GNU.
> >>
> >>Hmm... maybe I should drop this patch, if the correct thing to do is to
> >>build base-files with tar --format=gnu?
> >
> >If your patch allows to unpack a POSIX tar archive correctly, without
> >generating a warning... why would you like to drop it?
> 
> POSIX tar archive are (potentially) not unpacked strictly correctly in both
> cases, as they contain extra information that setup does not interpret.
> 
> All this patch changes is if we warn about that loss of information, or
> silently drop it.

I thought the difference is just in the header.  Also, is the extra
information required for our use case?  Anyway, if you're not
comfortable with the change, by all means back it out.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: pgpaxA4mp25wL.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]