This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH setup 0/4] Setup logging fixes


On Mar  5 13:44, Jon TURNEY wrote:
> On 02/03/2015 16:32, Corinna Vinschen wrote:
> > On Mar  2 13:55, Jon TURNEY wrote:
> >>
> >> Future work: there are some other uses of msg() to report real errors.  At the
> >> moment, these are completely invisible unless you are running setup under a
> >> debugger.  These should be converted to use the logger.
> [...]
> > Approved, under the assumption that you'll rework the other msg() calls
> > as well ;)
> 
> :)
> 
> Also change some of the uses of fprintf(stderr, ...) to report errors, which doesn't get logged.
> 
> This then exposes a bit of log spam in archive_tar.cc, which is silenced.
> 
> Jon TURNEY (4):
>   Add Log adaptors for printf-style output
>   Remove msg() and convert to log output
>   Log errors from archive_tar.cc
>   Silently ignore 'x' and 'g' type tar extended headers

Barring the single question I'm asking in other mail, these patches
look good.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: pgpNdVzShan9Y.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]