Re: [PATCH 1/4] setup.exe

[Christopher Faylor <cgf-use-the-mailinglist-please at cygwin dot com>]

On Fri, Feb 08, 2013 at 10:30:21PM +0100, Achim Gratz wrote:
>Jon TURNEY writes:
>> I've applied the uncontroversial part of this patch.
>
>Thank you.
>
>> In future, please use the ChangeLog format linked to in [1]. (emacs protip:
>> C-x 4 a :-))
>
>Noted.
>
>> I had a go at rewriting this, but "The libgetopt++ CVS module should be
>> automatically checked out in a subdirectory, unless you use a tool which
>> doesn't" didn't seem that helpful an observation :-)
>
>I tried this again from home (where no firewall interferes with getting
>at the CVS repository server directly).  Using cvs directly, this
>directory is populated while doing the checkout, no extra steps
>necessary.  On the other hand, git cvsimport also does not pull the
>libgetopt++ subdirectory by default (I've created it as a submodule
>instead and did another cvsimport there).  Just like CVSgrab it doesn't
>seem to understand the concept of a CVS module within another module or
>it simply doesn't care to look up CVSROOT/modules where thst gets
>defined.

Achim,
Would you consider rebundling your patch so that it only includes
--remove-packages and --remove-categories options?  Those are obviously
missing command-line functionality.

Regarding the autorebase changes, I am not against the idea of implementing
a general purpose mechanism to have setup.exe "do something" when it notices
certain file patterns being added or deleted.  This would move the current
'autodep' functionality from the "upset" program which creates setup.ini into
setup.exe itself.

This is the contents of _autorebase's setup.hint:

sdesc: "Run rebaseall automatically"
#external-source: rebase
category: _PostInstallLast
requires: rebase dash
autodep: .*/[^/]*\.(?:dll|so|oct)$
incver_ifdep: yes

I'm willing to move the autodep into setup.ini if someone is willing to
handle regex parsing like that in setup.  It would probably need to look
something like:

autodep: .*/[^/]*\.(?:dll|so|oct)$
autorun: /path/to/program

If we do something like this we can clean up the handling of .info files
too.

cgf