Re: [PATCH] setup.exe

[Christopher Faylor <cgf-use-the-mailinglist-please at cygwin dot com>]

On Fri, Jan 18, 2013 at 06:23:49PM +0100, Achim Gratz wrote:
>As requested by Corinna on the Cygwin list, here's a patch to document
>some recent changes in the build environment.

You'd really be much better served to submit one patch at a time.

>From 3dd23c6063a3edb8bfd1874f5b3c68baf0a89ec4 Mon Sep 17 00:00:00 2001
>From: Achim Gratz <Achim.Gratz@Infineon.com>
>Date: Fri, 18 Jan 2013 14:24:13 +0100
>Subject: [PATCH 1/3] README: document some recent changes in the build
> environment
>
>* setup/README (HOW TO BUILD): Cross compiler package is now named
>  mingw-gcc-g++, also mention package upx as an optional dependency.
>  Document the requirement of libgetopt++ as a subdirectory in the
>  main source tree.  Change the bootstrap stanza to take place in the
>  source tree since an out-of-tree build doesn't seem to work (if it
>  does, it apparently has additional requirements that I haven't
>  figured out).
>---
> setup/README | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
>diff --git a/setup/README b/setup/README
>index 2f36fb8..d5b0240 100755
>--- a/setup/README
>+++ b/setup/README
>@@ -5,7 +5,7 @@ HOW TO BUILD:
> -------------
> Setup should build out-of-the-box on any Cygwin environment that has all the
> required packages installed:
>-  - gcc-mingw-g++
>+  - mingw-gcc-g++
>   - make
>   - mingw-bzip2
>   - mingw-libgcrypt-devel
>@@ -13,6 +13,7 @@ required packages installed:
>   - mingw-zlib
>   - and all packages that are dependencies of the above, i.e.  gcc-mingw-core,
>     mingw-runtime, binutils, w*api, etc.
>+  - upx (optional)
> 
> The following additional packages are required if building from CVS, not from
> a source tarball, or if you want to make changes to the build system.
>@@ -22,9 +23,14 @@ a source tarball, or if you want to make changes to the build system.
>   - flex
>   - bison
> 
>+Additionally, libgetopt++ (also available from the cygwin-apps CVS at
>+sourceware.org) must be available directly as a subdirectory
>+libgetopt++ within the setup source directory.
>+
> Build commands:
> 1) Configure using this option
>-   $ /path/to/setup/bootstrap.sh
>+   $ cd /path/to/setup
>+   $ ./bootstrap.sh

If you look at bootstrap.sh, you will see why I'm puzzled why this should be
needed.  The script is intended to be run from the build directory which
should be separate from the source directory.

>A second patch adds two new targets for the makefile to strip and
>compress setup.exe.

"strip" as a target is really not a good idea.

>I#ll also offer a third patch that adds an option to setup.exe to enable
>the use of (local) ini files with a different basename than "setup".
>This is useful to offer (in the same install hierarchy) multiple
>installations, either for having different configurations or to allow
>individual installations to be rolled back.  The idea is to copy the
>setup.ini to something like release_2013-01-18.ini whenever a release is
>made and let setup.ini keep going forward for testing without having to
>duplicate the complete install hierarchy.

Who is the target audience for this?  It doesn't seem like it is worth
complicating setup for this type of feature.

cgf