This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] setup: use libgcrypt for md5


On Nov  8 02:03, Yaakov (Cygwin/X) wrote:
> IIUC libmd5-rfc preceded libgcrypt in setup by a few years.  But now
> that we're using libgcrypt for gpg/s-expr, I think it only makes sense
> that we use it as well for MD5 hashing.  (FWIW, this also shaves 2.5KB
> off the stripped, uncompressed binary.)  Patch attached.
> 
> 
> Yaakov
> 

> 2012-11-08  Yaakov Selkowitz  <yselkowitz@...>
> 
> 	* Makefile.am (EXTRA_DIST): Remove libmd5-rfc files.
> 	(setup_SOURCES): Ditto.
> 	* download.cc: Remove unused include.
> 	* csu_util/MD5Sum.cc: Port from libmd5-rfc to libgcrypt.
> 	* csu_util/MD5Sum.h: Ditto.
> 	* libmd5-rfc/*: Remove.

Looks ok to me.  Please apply.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]