This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [PATCH 2/2] When packages are selected on the command line in unattended mode, just install those packages
On Fri, Jul 22, 2011 at 04:18:40PM +0200, Corinna Vinschen wrote:
>On Jul 22 14:22, Jon TURNEY wrote:
>> When packages are selected on the command line in unattended mode,
>> just install those packages.
>> (Except that packages in the 'Base' and 'Misc' categories are always installed.)
>>
>> When no packages are selected on the command line in unattended mode, upgrade
>> all installed packages to the current version.
>>
>> This whole mechanism of putting the command line specified packages into the 'Base'
>> category so they get installed, rather than just setting them to be installed seems
>> less than ideal.
>>
>> Also, reading the code, there's probably bug: if we install from scratch
>> and then choose 'Keep', nothing gets installed, whereas 'Base' and 'Misc'
>> "should" get installed?
>>
>> Also, a command line option like '--packages <nonexistent-misspelt-package>' is silently
>> ignored at the moment. This is doubly bad now, as we will upgrade everything else to
>> the current version while the user curses us for not installing <correctly-spelt-package> :-)
>>
>> Also, since initializing the default list of packages to install is no longer a
>> side effect of building the GUI elements for the package picker window, we can
>> probably now bypass the package picker window entirely in unattended mode...
>
>Erm... given the downsides you're listing here, wouldn't it make sense
>to do it right, rather than to tweak a less than ideal mechanism even
>further?
I haven't read the patch but it wasn't clear from the above discussion
if Jon was fixing the above problem or just noting that it is still
broken.
I do appreciated that you're looking into this Jon. It seems to have
come up consistently in the mailing list and on irc.
cgf